-
Notifications
You must be signed in to change notification settings - Fork 486
[Lake] Introduce fluss-lake module #454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lake] Introduce fluss-lake module #454
Conversation
leonardBang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, @polyzos , left two minor comments
|
@leonardBang i addressed them |
|
Note the ci is failing |
| <parent> | ||
| <groupId>com.alibaba.fluss</groupId> | ||
| <artifactId>fluss-lake</artifactId> | ||
| <version>0.6-SNAPSHOT</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this version better to use 0.7-SNAPSHOT and merge this pull request after releasing cut? IMO, the 0.6 version doesn't include this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SteNicholas correct this should be inlcuded in the 0.7 release. But how do you typically approach this?
what should the version be since we are still on 0.6-snapshot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@polyzos, will the 0.6 version release next week? Is it better to release cut 0.6 and bump version to 0.7-SNAPSHOT firstly? Otherwise, 0.6 rc would include this module. cc @leonardBang, WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we didn't code-freeze yet, I think newly-added module is okay. Even our release version(0.6) contains these modules, but they won't be used by users as we don't expose them via user docs.
|
CI passed, will merge once @SteNicholas agree too. |
This closes apache#454.
Introduce fluss-lake module to address 434