Skip to content

Conversation

@polyzos
Copy link
Contributor

@polyzos polyzos commented Feb 20, 2025

Introduce fluss-lake module to address 434

@polyzos polyzos linked an issue Feb 20, 2025 that may be closed by this pull request
2 tasks
Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @polyzos , left two minor comments

@polyzos
Copy link
Contributor Author

polyzos commented Feb 20, 2025

@leonardBang i addressed them

@luoyuxia
Copy link
Contributor

Note the ci is failing

<parent>
<groupId>com.alibaba.fluss</groupId>
<artifactId>fluss-lake</artifactId>
<version>0.6-SNAPSHOT</version>
Copy link
Member

@SteNicholas SteNicholas Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this version better to use 0.7-SNAPSHOT and merge this pull request after releasing cut? IMO, the 0.6 version doesn't include this.

Copy link
Contributor Author

@polyzos polyzos Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SteNicholas correct this should be inlcuded in the 0.7 release. But how do you typically approach this?
what should the version be since we are still on 0.6-snapshot?

Copy link
Member

@SteNicholas SteNicholas Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@polyzos, will the 0.6 version release next week? Is it better to release cut 0.6 and bump version to 0.7-SNAPSHOT firstly? Otherwise, 0.6 rc would include this module. cc @leonardBang, WDYT?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we didn't code-freeze yet, I think newly-added module is okay. Even our release version(0.6) contains these modules, but they won't be used by users as we don't expose them via user docs.

@leonardBang
Copy link
Contributor

CI passed, will merge once @SteNicholas agree too.

@leonardBang leonardBang merged commit fe323c1 into main Feb 21, 2025
2 checks passed
@wuchong wuchong deleted the 434-fluss-lake-introduce-fluss-lake-module-for-lakehouse-storage branch February 26, 2025 07:32
ZmmBigdata pushed a commit to ZmmBigdata/fluss that referenced this pull request Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Introduce fluss-lake module for lakehouse storage

4 participants